Improved error handling in vchasno responses

api/client.go

@@ -1,11 +1,16 @@
 package api
 
-import "resty.dev/v3"
+import (
+	"crypto/tls"
+
+	"resty.dev/v3"
+)
 
 type Client struct {
-	token         string
-	resty         *resty.Client
-	apiBaseURL    string
+	token          string
+	device         string
+	resty          *resty.Client
+	apiBaseURL     string
 	fiscalEndpoint string
 }
 
@@ -18,11 +23,23 @@ func NewClient(token string) *Client {
 	}
 }
 
-func NewDMClient(token string, dmURL string) *Client {
+func NewDMClient(token, dmURL, device string) *Client {
+	restyClient := resty.New()
+	restyClient.SetTLSClientConfig(&tls.Config{
+		MinVersion: tls.VersionTLS12,
+		CipherSuites: []uint16{
+			tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
+			tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
+			tls.TLS_RSA_WITH_AES_256_GCM_SHA384,
+			tls.TLS_RSA_WITH_AES_128_GCM_SHA256,
+		},
+	})
+
 	return &Client{
 		token:          token,
-		resty:          resty.New(),
+		device:         device,
+		resty:          restyClient,
 		apiBaseURL:     dmURL,
-		fiscalEndpoint: "/dm/fiscal",
+		fiscalEndpoint: "/dm/execute",
 	}
 }

api/fiscal.go

@@ -5,40 +5,64 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"log"
 )
 
+type APIError struct {
+	Code    int
+	Message string
+}
+
+func (e *APIError) Error() string {
+	return fmt.Sprintf("vchasno api error %d: %s", e.Code, e.Message)
+}
+
 func (c *Client) executeRequest(ctx context.Context, request FiscalRequest, response interface{}) error {
-	//execute request with json body in request
+	request.Device = c.device
+
 	reqJson, err := json.Marshal(request)
 	if err != nil {
 		return fmt.Errorf("failed to marshal request: %w", err)
 	}
 
+	url := c.apiBaseURL + c.fiscalEndpoint
+	log.Printf("[VCHASNO] POST %s", url)
+	log.Printf("[VCHASNO] Request: %s", string(reqJson))
+
 	resp, err := c.resty.R().
 		SetContext(ctx).
 		SetHeader("Authorization", c.token).
+		SetHeader("Content-Type", "application/json").
 		SetBody(reqJson).
-		Post(c.apiBaseURL + c.fiscalEndpoint)
+		Post(url)
 
 	if err != nil {
 		return fmt.Errorf("request failed: %w", err)
 	}
 
-	if resp.IsError() {
-		return fmt.Errorf("api error: %v", resp.Error())
-	}
-
-	if resp.StatusCode() != 200 {
-		return fmt.Errorf("unexpected status code: %d", resp.StatusCode())
-	}
-
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return fmt.Errorf("failed to read response: %w", err)
 	}
 
+	log.Printf("[VCHASNO] Response (status %d): %s", resp.StatusCode(), string(body))
+
+	if resp.StatusCode() != 200 {
+		return fmt.Errorf("api error (status %d): %s", resp.StatusCode(), string(body))
+	}
+
 	if err := json.Unmarshal(body, response); err != nil {
-		return fmt.Errorf("failed to unmarshal response: %w", err)
+		return fmt.Errorf("failed to unmarshal response: %w, body: %s", err, string(body))
+	}
+
+	var baseResp BaseResponse
+	if err := json.Unmarshal(body, &baseResp); err == nil {
+		if baseResp.HasError() {
+			return &APIError{
+				Code:    baseResp.Res,
+				Message: baseResp.Errortxt,
+			}
+		}
 	}
 
 	return nil

api/responses.go

@@ -15,6 +15,17 @@ type BaseResponse struct {
 	ErrorExtra interface{} `json:"error_extra"`
 }
 
+func (r *BaseResponse) HasError() bool {
+	return r.Res != 0
+}
+
+func (r *BaseResponse) Error() string {
+	if r.Errortxt != "" {
+		return r.Errortxt
+	}
+	return ""
+}
+
 type SellResponse struct {
 	BaseResponse
 	Info SellInfo `json:"info"`

examples.go

@@ -7,9 +7,10 @@ import (
 
 func ExampleBasicUsage() {
 	client := NewClient(Config{
-		Token:   "your-token",
-		Cashier: "Иванов",
-		Source:  "parking",
+		Token:     "your-token",
+		Cashier:   "Иванов",
+		Source:    "parking",
+		CustomURL: "DM URL/",
 	})
 
 	ctx := context.Background()

vchasno.go

@@ -25,13 +25,13 @@ type Client struct {
 	defaults *DefaultParams
 }
 
-// !! If you are using Device Manager, set the CustomURL to "http(s)://HOST/api/v3".
 type Config struct {
 	Token     string
 	Cashier   string
 	Source    string
 	Defaults  *DefaultParams
 	CustomURL string
+	Device    string
 }
 
 type DefaultParams struct {
@@ -67,12 +67,11 @@ func NewClient(config Config) *Client {
 		defaults.DefaultTimeout = 30 * time.Second
 	}
 
-	apicfg := &api.Client{}
-
+	var apicfg *api.Client
 	if config.CustomURL == "" {
 		apicfg = api.NewClient(config.Token)
 	} else {
-		apicfg = api.NewDMClient(config.Token, config.CustomURL)
+		apicfg = api.NewDMClient(config.Token, config.CustomURL, config.Device)
 	}
 
 	return &Client{