From b78652b279bc9a338c869ff4014ceef64cf14cda Mon Sep 17 00:00:00 2001 From: UpstreamData Date: Mon, 15 Jan 2024 16:23:54 -0700 Subject: [PATCH] refactor: remove some unused variables. --- pyasic/miners/backends/vnish.py | 1 - pyasic/miners/miner_listener.py | 4 ++-- pyasic/miners/unknown.py | 2 +- pyasic/network/__init__.py | 16 +++++++--------- pyasic/web/goldshell.py | 2 +- pyasic/web/innosilicon.py | 2 +- pyasic/web/vnish.py | 2 +- 7 files changed, 13 insertions(+), 16 deletions(-) diff --git a/pyasic/miners/backends/vnish.py b/pyasic/miners/backends/vnish.py index b5e2c043..1c26bdd8 100644 --- a/pyasic/miners/backends/vnish.py +++ b/pyasic/miners/backends/vnish.py @@ -18,7 +18,6 @@ from typing import Optional from pyasic import MinerConfig from pyasic.errors import APIError -from pyasic.logger import logger from pyasic.miners.backends.bmminer import BMMiner from pyasic.miners.base import ( DataFunction, diff --git a/pyasic/miners/miner_listener.py b/pyasic/miners/miner_listener.py index 9761ffc4..66ec17ab 100644 --- a/pyasic/miners/miner_listener.py +++ b/pyasic/miners/miner_listener.py @@ -55,10 +55,10 @@ class MinerListener(metaclass=Singleton): loop = asyncio.get_running_loop() - transport_14235, protocol_14235 = await loop.create_datagram_endpoint( + transport_14235, _ = await loop.create_datagram_endpoint( lambda: _MinerListener(), local_addr=("0.0.0.0", 14235) # noqa ) - transport_8888, protocol_8888 = await loop.create_datagram_endpoint( + transport_8888, _ = await loop.create_datagram_endpoint( lambda: _MinerListener(), local_addr=("0.0.0.0", 8888) # noqa ) diff --git a/pyasic/miners/unknown.py b/pyasic/miners/unknown.py index c32c050d..2a112018 100644 --- a/pyasic/miners/unknown.py +++ b/pyasic/miners/unknown.py @@ -17,7 +17,7 @@ from typing import List, Optional, Tuple from pyasic.config import MinerConfig -from pyasic.data import Fan, HashBoard, MinerData +from pyasic.data import Fan, HashBoard from pyasic.data.error_codes import MinerErrorData from pyasic.miners.base import BaseMiner from pyasic.rpc.unknown import UnknownRPCAPI diff --git a/pyasic/network/__init__.py b/pyasic/network/__init__.py index cfe2adcd..1272ff1f 100644 --- a/pyasic/network/__init__.py +++ b/pyasic/network/__init__.py @@ -77,19 +77,19 @@ class MinerNetwork: hosts = [] - oct_1_val_start, oct_1_start, oct_1_end = compute_oct_range(oct_1) + oct_1_start, oct_1_end = compute_oct_range(oct_1) for oct_1_idx in range((abs(oct_1_end - oct_1_start)) + 1): oct_1_val = str(oct_1_idx + oct_1_start) - oct_2_val_start, oct_2_start, oct_2_end = compute_oct_range(oct_2) + oct_2_start, oct_2_end = compute_oct_range(oct_2) for oct_2_idx in range((abs(oct_2_end - oct_2_start)) + 1): oct_2_val = str(oct_2_idx + oct_2_start) - oct_3_val_start, oct_3_start, oct_3_end = compute_oct_range(oct_3) + oct_3_start, oct_3_end = compute_oct_range(oct_3) for oct_3_idx in range((abs(oct_3_end - oct_3_start)) + 1): oct_3_val = str(oct_3_idx + oct_3_start) - oct_4_val_start, oct_4_start, oct_4_end = compute_oct_range(oct_4) + oct_4_start, oct_4_end = compute_oct_range(oct_4) for oct_4_idx in range((abs(oct_4_end - oct_4_start)) + 1): oct_4_val = str(oct_4_idx + oct_4_start) @@ -172,11 +172,11 @@ class MinerNetwork: async def ping_and_get_miner( ip: ipaddress.ip_address, port=80 ) -> Union[None, AnyMiner]: - for i in range(settings.get("network_ping_retries", 1)): + for _ in range(settings.get("network_ping_retries", 1)): try: connection_fut = asyncio.open_connection(str(ip), port) # get the read and write streams from the connection - reader, writer = await asyncio.wait_for( + _, writer = await asyncio.wait_for( connection_fut, timeout=settings.get("network_ping_timeout", 3) ) # immediately close connection, we know connection happened @@ -207,6 +207,4 @@ def compute_oct_range(octet: str) -> tuple: if octet_end is None: octet_end = int(octet_start) - octet_val_start = min([octet_start, octet_end]) - - return octet_val_start, octet_start, octet_end + return octet_start, octet_end diff --git a/pyasic/web/goldshell.py b/pyasic/web/goldshell.py index b0626941..ea4d0ec1 100644 --- a/pyasic/web/goldshell.py +++ b/pyasic/web/goldshell.py @@ -72,7 +72,7 @@ class GoldshellWebAPI(BaseWebAPI): if not self.jwt: await self.auth() async with httpx.AsyncClient(transport=settings.transport()) as client: - for i in range(settings.get("get_data_retries", 1)): + for _ in range(settings.get("get_data_retries", 1)): try: if parameters: response = await client.put( diff --git a/pyasic/web/innosilicon.py b/pyasic/web/innosilicon.py index ca095003..63df22c2 100644 --- a/pyasic/web/innosilicon.py +++ b/pyasic/web/innosilicon.py @@ -55,7 +55,7 @@ class InnosiliconWebAPI(BaseWebAPI): if not self.jwt: await self.auth() async with httpx.AsyncClient(transport=settings.transport()) as client: - for i in range(settings.get("get_data_retries", 1)): + for _ in range(settings.get("get_data_retries", 1)): try: response = await client.post( f"http://{self.ip}:{self.port}/api/{command}", diff --git a/pyasic/web/vnish.py b/pyasic/web/vnish.py index 83ee092f..91588d8d 100644 --- a/pyasic/web/vnish.py +++ b/pyasic/web/vnish.py @@ -59,7 +59,7 @@ class VNishWebAPI(BaseWebAPI): if not self.token: await self.auth() async with httpx.AsyncClient(transport=settings.transport()) as client: - for i in range(settings.get("get_data_retries", 1)): + for _ in range(settings.get("get_data_retries", 1)): try: auth = self.token if command.startswith("system"):